-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show download state and progress on reader chapter list. #1263
Show download state and progress on reader chapter list. #1263
Conversation
Is this good to merge? I saw a lot of talk about it in the discord |
Definitely not. It just "sort of" works. As I mentioned:
I have managed to make it update when the state changes (not committed) . No luck on the progress though. I think I'll be quite busy this week and won't be able to work on this. Should I mark this as draft or something? |
Marking it as draft then 👍 |
Should I add issue 497 to be closed by this? Context is lost without the images and I have no clue if it's mentioning this or something else. |
It still doesn't update the state after chapters are automatically deleted. |
How do you even check for that? Automatic deletion of chapters (as far as I know) is done only after the TachiyomiSY/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderViewModel.kt Lines 318 to 324 in dea3891
|
f7567f0
to
581c1c5
Compare
Issues with my implementation:
Closes #1207
(I am unsure whether #497 is mentioning this or something else and why Syer mentioned that it's intentional.)