Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show download state and progress on reader chapter list. #1263

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

NGB-Was-Taken
Copy link

Issues with my implementation:

  • The download state and progress don't update until chapter is scrolled out of the screen and back or the chapter list dialogue is closed and re-opened.
  • The button itself still does nothing.

Closes #1207
(I am unsure whether #497 is mentioning this or something else and why Syer mentioned that it's intentional.)

@jobobby04
Copy link
Owner

Is this good to merge? I saw a lot of talk about it in the discord

@NGB-Was-Taken
Copy link
Author

Is this good to merge? I saw a lot of talk about it in the discord

Definitely not. It just "sort of" works. As I mentioned:

The download state and progress don't update until chapter is scrolled out of the screen and back or the chapter list dialogue is closed and re-opened.

I have managed to make it update when the state changes (not committed) . No luck on the progress though. I think I'll be quite busy this week and won't be able to work on this. Should I mark this as draft or something?

@jobobby04
Copy link
Owner

Marking it as draft then 👍

@jobobby04 jobobby04 marked this pull request as draft September 1, 2024 14:34
@NGB-Was-Taken NGB-Was-Taken marked this pull request as ready for review September 7, 2024 09:26
@NGB-Was-Taken
Copy link
Author

Should I add issue 497 to be closed by this? Context is lost without the images and I have no clue if it's mentioning this or something else.

@cuong-tran
Copy link

It still doesn't update the state after chapters are automatically deleted.

@NGB-Was-Taken
Copy link
Author

It still doesn't update the state after chapters are automatically deleted.

How do you even check for that? Automatic deletion of chapters (as far as I know) is done only after the ReaderViewModel is closed.

/**
* Called when the user pressed the back button and is going to leave the reader. Used to
* trigger deletion of the downloaded chapters.
*/
fun onActivityFinish() {
deletePendingChapters()
}

@jobobby04 jobobby04 merged commit 558ce08 into jobobby04:master Oct 14, 2024
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
@NGB-Was-Taken NGB-Was-Taken deleted the reader-chapter-list branch October 28, 2024 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloads disappear
3 participants