Skip to content

Commit

Permalink
Update Client Secret
Browse files Browse the repository at this point in the history
  • Loading branch information
@jobobby04
jobobby04 committed Mar 16, 2024
1 parent 334e9fb commit 45711cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/src/main/assets/client_secrets.json
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"installed":{"client_id":"1046609911130-tbp79niehhuii976ekep1us06e9a8lne.apps.googleusercontent.com","project_id":"tachiyomi","auth_uri":"https://accounts.google.com/o/oauth2/auth","token_uri":"https://oauth2.googleapis.com/token","auth_provider_x509_cert_url":"https://www.googleapis.com/oauth2/v1/certs"}}
{"installed":{"client_id":"1036781676510-gdefgdmh7krt0335kj77roh74mna8dtn.apps.googleusercontent.com","project_id":"tachiyomisy-417415","auth_uri":"https://accounts.google.com/o/oauth2/auth","token_uri":"https://oauth2.googleapis.com/token","auth_provider_x509_cert_url":"https://www.googleapis.com/oauth2/v1/certs"}}

2 comments on commit 45711cd

@kaiserbh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this I don't think you need to commit the file, as long it's there during build time it might work? I haven't tested it but I am sure it should, I only commit it as an example or place holder.
@jobobby04, It's just others can mimic or request access as "tachiyomisy", so it's a security risk to publish it.

After creating your credentials, download the client_secret.json file from the API Console. Securely store the file in a location that only your application can access.

and

Keep your client secret private. If someone obtains your client secret, they could use it to consume your quota, incur charges against your Developers Console project, and request access to user data

@jobobby04
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I see. I'll take a look at doing that 👍

Please sign in to comment.