Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature multi line tag for ignore comments #120

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

demorfi
Copy link

@demorfi demorfi commented May 14, 2014

  • Bug fix empty hash link from national headers
  • Bug fix working pseudo classes in browser firefox
  • Add feature multi line tag for ignore comments

@marrs
Copy link
Collaborator

marrs commented May 20, 2014

Thanks for submitting this patch. Can you add unit tests for the new functionality and make sure that the existing tests continue to pass?

@demorfi
Copy link
Author

demorfi commented May 20, 2014

Yes, soon.

@demorfi
Copy link
Author

demorfi commented May 21, 2014

Notice: if the first unit is not to comment, it will be ignored -> it's not a bug, it's reature

@@ -1,8 +1,5 @@
[
{
"docs": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for removing this code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demorfi
Copy link
Author

demorfi commented May 28, 2014

if the first unit is not to comment, it will be ignored.
ignored

Not ignore - empty block
empty plash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants