Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty 'save()' as query last statement #357

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

dreadatour
Copy link
Contributor

@dreadatour dreadatour commented Aug 27, 2024

Fix for #327
See this comment.

Closes #343.

@dreadatour dreadatour self-assigned this Aug 27, 2024
Copy link

cloudflare-workers-and-pages bot commented Aug 27, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: fe75445
Status: ✅  Deploy successful!
Preview URL: https://60d3addb.datachain-documentation.pages.dev
Branch Preview URL: https://fix-empty-save-in-query.datachain-documentation.pages.dev

View logs

src/datachain/query/dataset.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (f0db01d) to head (fe75445).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   86.89%   86.90%           
=======================================
  Files          90       90           
  Lines        9923     9925    +2     
  Branches     2003     2003           
=======================================
+ Hits         8623     8625    +2     
  Misses        947      947           
  Partials      353      353           
Flag Coverage Δ
datachain 86.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreadatour dreadatour merged commit 145347c into main Aug 27, 2024
38 checks passed
@dreadatour dreadatour deleted the fix-empty-save-in-query branch August 27, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants