Skip to content
This repository has been archived by the owner on Nov 21, 2021. It is now read-only.

Sourcery refactored master branch #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jun 29, 2020

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

if (comp["prize"] == "NaN") or (comp["prize"] == "Kaggle Swag"):
if comp["prize"] in ["NaN", "Kaggle Swag"]:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function index refactored with the following changes:

  • Replace multiple comparisons of same variable with in operator (merge-comparisons)

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jun 29, 2020

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.03 out of 10.

Before After Change
Quality 7.94 7.98 0.03
Complexity 1.33 1.17 -0.17
Method Length 98.94 98.11 -0.83
Lines 187 187 0
Changed files Quality Before Quality After Quality Change
run.py 7.94 7.98 0.03 ⬆️

Here are some functions in these files that still need a tune-up:

File Function Quality Recommendation
run.py products_xml 5.6 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants