Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade websocket-client dependency #281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vbanos
Copy link

@vbanos vbanos commented Jul 28, 2024

We use a very old version (0.47.0 was released on Feb 22, 2018). This project is actively developed so it would be great to upgrade. Changelog: https://github.com/websocket-client/websocket-client/blob/master/ChangeLog

I tested every version from 0.48.0 to 0.59.0.
Only versions 0.52.0, 0.58.0 and 0.59.0 worked correctly. All others raised exceptions. Thus, I suggest to use 0.59.0 for now.

We use a very old version (0.47.0 was released on Feb 22, 2018).
This project is actively developed so it would be great to upgrade.
Changelog: https://github.com/websocket-client/websocket-client/blob/master/ChangeLog

I tested every version from 0.48.0 to 0.59.0.
Only versions 0.52.0, 0.58.0 and 0.59.0 worked correctly. All others
raised exceptions. Thus, I suggest to use 0.59.0 for now.
@vbanos
Copy link
Author

vbanos commented Jul 28, 2024

Furthermore, I tested version 1.0.0 to 1.4.3. Captures worked but in the end, all raised the following exception:

[2024-07-28 10:51:06,819: ERROR/ForkPoolWorker-2] error from callback <bound method WebsockReceiverThread._on_close of <WebsockReceiverThread(WebsockThread:47001, started daemon 139974406829824)>>: _on_close() takes 2 positional arguments but 4 were given
[2024-07-28 10:51:06,819: ERROR/ForkPoolWorker-2] exception from websocket receiver thread
Traceback (most recent call last):                                              
  File "/opt/spn/lib/python3.8/site-packages/websocket/_app.py", line 407, in _callback
    callback(self, *args)                                                       
TypeError: _on_close() takes 2 positional arguments but 4 were given            

We need to change Brozzler code to use version 1+.

So, I recommend to upgrade to 0.59.0 as a first step and then later make the necessary code changes to upgrade even more.
Thank you.

@vbanos
Copy link
Author

vbanos commented Jul 28, 2024

Also, the new websocket client will be needed to use the latest Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant