Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C stubs to avoid returning void #56

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

ncik-roberts
Copy link
Contributor

Fix C stubs to return Val_unit instead of void. Prior to this PR, code like this would segfault:

utop # let t = Bigstringaf.create 100;;
utop # let q = Queue.create ();;
utop # Queue.add (Bigstringaf.blit_to_bytes t ~src_off:50 (Bytes.create 100) ~dst_off:50 ~len:50) q;;
- : unit = ()
utop # Gc.full_major ();;
Segmentation fault (core dumped)  

@seliopou seliopou merged commit 39a242e into inhabitedtype:master Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants