Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 removed the old buffer interface #456

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

totaam
Copy link
Contributor

@totaam totaam commented Aug 16, 2024

for details, see python/cpython#85275

I'm not sure what CUDAPP_CALL_GUARDED does or if we perhaps should catch errors there and call PyBuffer_Release if an error is thrown.
I also don't know if the failures here are meant to be fatal or not.

Only compile tested at this point.

@inducer
Copy link
Owner

inducer commented Oct 10, 2024

Thanks for putting this together. I share your concern about exception safety, at least in the C++ code. Fortunately, there already is a RAII wrapper for the buffer interface floating around, I've simply changed the code there to use that.

@inducer inducer merged commit 6ae7c05 into inducer:main Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants