-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opify static methods #10
Conversation
And improve the test to make varying the sphere radius simpler. Migrated from imagej/imagej-ops#653. See also imagej/imagej-ops#422. Co-authored-by: Kyle Harrington <[email protected]>
Absolutely agree with the confusing naming. Maybe I would definitely drop |
Hello @hinerm |
Hi @tinevez, I've written this PR to require Java 11+ compilers (to enable Ops annotation processing), but Java 8 code. It should work just fine in a Java 8 Fiji! Please let me know if you have any questions or concerns with this. |
Thanks for the clarification! The difference between compile time requirements and execution time requirements escaped me. |
This WIP PR intends to "opify" the static functionality within the project, and is divided into two subtasks:
Mesh
es from scijava-ops-image to here.I've additionally filed issues for, or just outright added, functionality that was declared to work in scijava-ops-image/ImageJ Ops but was not functional:
Meshes.boundingBoxMesh
that creates a bounding boxMesh
from anotherMesh
.Points of discussion:
geom.mainElongation
andgeom.medianElongation
Ops to have confusing names, as I could find no literature that named these properties. My understanding is thatgeom.mainElongation
measures the elongation of a cross-section ellipse, where the section is perpendicular to the two larger semi-axes, whilegeom.medianElongation
does the same but with the two smaller semi-axes. @tibuch is this correct? At a minimum I want to document this, but better would be to come up with better names so we can alias the Op.