Fix handling output file in DOMjudge reactive problem #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, DOMJudgeReactiveRunner ignores output file because reactive problems don't usually have output, and interactor don't use it. However, when packing zip to upload, diff file is mandatory, so even though it just creates an empty file, DOMJudgeReactiveRunner should make sure diff file is created so that later pack and upload won't fail due to missing diff file. Fixes icpc-jag#102.
tossy310
added a commit
to tossy310/domjudge-rime-example
that referenced
this pull request
Sep 22, 2024
climpet
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
DOMJudgeReactiveRunnerignores the output file because reactive problems don't usually have output, and interactor don't use it.However, when packing zip to upload, diff file is mandatory, so even though it just creates an empty file,
DOMJudgeReactiveRunnershould make sure diff file is created so that later pack and upload won't fail due to missing diff file.Fixes #102.
(cc: @riantkb, @climpet )