Fix guideline issues #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
fix-guideline-issues
branch
from
d1cf718
to
95e0986
Compare
robertknight
approved these changes
Jan 26, 2024
acelaya
force-pushed
the
fix-guideline-issues
branch
from
95e0986
to
580fa5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #40
This PR fixes the issues reported by the WordPress plugins team on their latest review.
Licensefield, and that a GPL-compatible one has to be used. I updated it fromBSDtoBSD-2-Clause, just in case only the identifier is wrong, as BSD appears as a GPL-compatible license.However, I have asked them to clarify if this is the probelm.
This is allowed, but it needs to be explicitly noted in the readme.txt file.
I also added links to our terms of service and privacy policy.
HypothesisPHP namespace to our code, to avoid symbol name collisions with the global namespace that WordPress uses for its own internal API.