Reflect proxied document URL in top frame URL #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the URL of the top frame to reflect the proxied URL currently displayed in the content frame. This may be different than the initially requested URL if it redirected. For example https://stackoverflow.com/questions/<ID>/ redirects to https://stackoverflow.com/questions/<ID>/<slug>. When visiting https://via.hypothes.is/https://stackoverflow.com/<ID> the URL should be updated to https://via.hypothes.is/https://stackoverflow.com/<ID>/<slug> accordingly. Depends on hypothesis/viahtml#170 and fixes hypothesis/viahtml#156.
The URL passed to `replaceState` is resolved relative to the current URL, so we don't need to specify the origin.
robertknight
commented
May 5, 2021
| // in response to client-side URL changes in the iframe in future, we'll | ||
| // probably want to change this. | ||
| const viaURL = `/${metadata.location}`; | ||
| history.replaceState(null, document.title, viaURL); |
There was a problem hiding this comment.
nb. The url argument to replaceState is resolved relative to the current URL.
seanh
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the URL of the top frame to reflect the proxied URL currently displayed in the content frame. This may be different than the initially requested URL if it redirected.
For example https://stackoverflow.com/questions/{id}/ redirects to https://stackoverflow.com/questions/{id}/{slug}. When visiting https://via.hypothes.is/https://stackoverflow.com/{id} the URL should be updated to https://via.hypothes.is/https://stackoverflow.com/{id}/{slug} accordingly.
Depends on hypothesis/viahtml#170 and fixes hypothesis/viahtml#156.
Testing:
Once the document has loaded, the URL should be updated to http://localhost:9083/https://stackoverflow.com/questions/12339806/escape-strings-for-javascript-using-jinja2.
When annotating PDFs the code here runs, but you won't see the expected effect due to #480.