Apply updates from the cookiecutter's db branch
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
changed the title
db branch
seanh
commented
Jul 12, 2023
| from factory.alchemy import SQLAlchemyModelFactory | ||
|
|
||
|
|
||
| def set_factoryboy_sqlalchemy_session(session, persistence=None): |
There was a problem hiding this comment.
I don't think data-tasks has any factories for SQLAlchemy models (or any factories at all) so it doesn't really need this. So we could add this file (and the factories/__init__.py file above) to the ignore list in data-tasks's cookiecutter.json if we don't want this here. But data-tasks does actually have a db_session fixture for its unit tests and this PR does actually hook factory_boy up to that session, but that would only ever be relevant if data-tasks one day contained some SQLAlchemy models and some factories for those models. So maybe we should remove this from data-tasks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test of what hypothesis/cookiecutters#128 would do to this project.