Update allowLeavingGroups docs to match reality
#6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the documentation to match the current behavior. As noted in #6638, the code comments and behavior were inconsistent. Since changing the behavior is potentially disruptive, that PR changed the comments instead. This commit updates the publisher-facing documentation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6639 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 270 270
Lines 10172 10172
Branches 2418 2418
=======================================
Hits 10114 10114
Misses 58 58 ☔ View full report in Codecov by Sentry. |
acelaya
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation to match the current behavior. As noted in #6638, the code comments and behavior were inconsistent. Since changing the behavior is potentially disruptive, that PR changed the comments instead. This commit updates the publisher-facing documentation.