Disable MessagePort workaround under Safari >= 16 #6602
Conversation
The bug described in https://bugs.webkit.org/show_bug.cgi?id=231167 was fixed in Safari 16. The workaround for Safari <= 15 is triggering an error in VitalSource LMS assignments [1]. Fix the issue for Safari >= 16 by disabling the workaround in browsers where it is not required. [1] hypothesis/support#161 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6602 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 270 270
Lines 10169 10175 +6
Branches 2417 2419 +2
=======================================
+ Hits 10111 10117 +6
Misses 58 58 ☔ View full report in Codecov by Sentry. |
| // If no version info, we guess that the browser is a new version of | ||
| // WebKit which is not affected. | ||
| return false; | ||
| } |
There was a problem hiding this comment.
There a possibility for a false positive here if this is a non-Safari WebKit-based browser that is equivalent to Safari 16 or newer but has a Version/ token that is < 16.
A possible workaround might be to check for a new browser API that was added in Safari 16 instead, like HTMLFormElement.prototype.requestSubmit. This code runs in the context of a third-party web page, so there is a risk that such an API gets polyfilled.
In any case, the set of browsers for which the workaround is enabled in this PR is strictly a subset of those where it was previously used.
The bug described in https://bugs.webkit.org/show_bug.cgi?id=231167 was fixed in Safari 16. The workaround for Safari <= 15 is triggering an error in VitalSource LMS assignments [1]. Fix the issue for Safari >= 16 by disabling the workaround in browsers where it is not required.
[1] https://github.com/hypothesis/support/issues/161#issuecomment-2407558020