Add context to error logged when anchoring fails #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5639 +/- ##
==========================================
- Coverage 99.43% 99.42% -0.02%
==========================================
Files 240 240
Lines 9429 9436 +7
Branches 2236 2237 +1
==========================================
+ Hits 9376 9382 +6
- Misses 53 54 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acelaya
approved these changes
Jul 19, 2023
If the transcript fails to load in the video player app, it will reject the `contentReady` promise that the client waits on. The client would then cause the error to be thrown from `Guest.anchor`. Catch this error and add context to indicate what has gone wrong.
robertknight
force-pushed
the
content-load-error-context
branch
from
aed61e5
to
8628b9e
Compare
As that branch is a trival log statement in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the transcript fails to load in the video player app, it will reject the
contentReadypromise that the client waits on. The client would then cause the error to be thrown fromGuest.anchor. Catch this error and add context to indicate what has gone wrong.The upshot of this is that if the transcript fails to load in the video player, anyone looking at the browser console will see a more meaningful message.
Before:
After: