Point users to the new form to capture information rather than an email #219
Conversation
|
Lint error... |
| <a href="mailto:[email protected]?subject={{ email_subject | urlencode }}&body={{ email_body | urlencode }}" target="_blank" | ||
| >Email us</a> | ||
| to let us know you'd like to annotate the page with {{annotated_with}}. | ||
| <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">Or let us know you'd like to annotate the page with Via.</a> |
There was a problem hiding this comment.
| <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">Or let us know you'd like to annotate the page with Via.</a> | |
| <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">Or let us know you'd like to annotate the page with {{ annotated_with }}.</a> |
There was a problem hiding this comment.
👍 to Marcos's suggestion, we can't say "with Via" in the LMS context. I also think it looks nicer if the "or" isn't part of the link:
| <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">Or let us know you'd like to annotate the page with Via.</a> | |
| Or <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">let us know you'd like to annotate the page with {{ annotated_with }}.</a> |
@jon-betts Can you make sure this has been tested in the LMS app? The block page and what happens when you click on the link needs to work / make sense in the LMS context as well. For example I suspect that saying Or let us know you'd like to annotate the page with... isn't going to make sense in the LMS app as the Use our browser extension section will have been omitted so the "or" won't make any sense.
The link will have to open in a new tab in LMS too.
There are pre-created localhost assignments for blocked pages in Developer Test Course with Sections Enabled but I don't think they cover all versions of the block pages, so you may have to add some more
There was a problem hiding this comment.
I think Use our browser extension should just be a <p> now rather than an <h3>. As things stand the Or let us know you'd like to annotate the page with Via text is under the Use our browser extension which doesn't make sense as it's a separate option, not part of using the browser extension
Fixed:
| <a href="mailto:[email protected]?subject={{ email_subject | urlencode }}&body={{ email_body | urlencode }}" target="_blank" | ||
| >Email us</a> | ||
| to let us know you'd like to annotate the page with {{annotated_with}}. | ||
| <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">Or let us know you'd like to annotate the page with Via.</a> |
There was a problem hiding this comment.
👍 to Marcos's suggestion, we can't say "with Via" in the LMS context. I also think it looks nicer if the "or" isn't part of the link:
| <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">Or let us know you'd like to annotate the page with Via.</a> | |
| Or <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">let us know you'd like to annotate the page with {{ annotated_with }}.</a> |
@jon-betts Can you make sure this has been tested in the LMS app? The block page and what happens when you click on the link needs to work / make sense in the LMS context as well. For example I suspect that saying Or let us know you'd like to annotate the page with... isn't going to make sense in the LMS app as the Use our browser extension section will have been omitted so the "or" won't make any sense.
The link will have to open in a new tab in LMS too.
There are pre-created localhost assignments for blocked pages in Developer Test Course with Sections Enabled but I don't think they cover all versions of the block pages, so you may have to add some more
| <a href="mailto:[email protected]?subject={{ email_subject | urlencode }}&body={{ email_body | urlencode }}" target="_blank" | ||
| >Email us</a> | ||
| to let us know you'd like to annotate the page with {{annotated_with}}. | ||
| <a href="https://web.hypothes.is/via-request/?subject={{ blocked_url | urlencode }}">Or let us know you'd like to annotate the page with Via.</a> |
There was a problem hiding this comment.
I think Use our browser extension should just be a <p> now rather than an <h3>. As things stand the Or let us know you'd like to annotate the page with Via text is under the Use our browser extension which doesn't make sense as it's a separate option, not part of using the browser extension
Fixed:
|
👍 I fixed the What specifically are we looking to test in the LMS context here? Presumably it's not possible to see this page in LMS as it's only presented for allow list things? |
|
I've updated with the suggestions made, but I'm not really sure how to test in LMS as suggested. This page is shown when you aren't on the allow list, but we don't apply the allow list in LMS, so there's no way to see the page. |
|
Hmm, the tests were failing in CI on one of the crypto tests (which this code doesn't touch). I ran it again and it's "fine" now, but that's not particularly encouraging. |
This leverages the existing form, and means support get all of their requests through the same medium. This also means support can control the content of the form directly.
For: #207
This leverages the existing form, and means support get all of their requests through the same medium. This also means support can control the content of the form directly.
Testing notes
make services dev