New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change naonset args definition to make it compatible with the parser #228

Merged

3outeille merged 1 commit into huggingface:main from eliebak:nanoset-python-compatible

Sep 5, 2024

Contributor

eliebak commented Sep 5, 2024

should now be

dataset=NanosetDatasetsArgs(
    dataset_folder=[
        "datasets/cosmopedia-v2",
        "datasets/fineweb-edu-dedup",
    ],
    dataset_weights = [70, 30],
),

Instead of

dataset=NanosetDatasetsArgs(
    dataset_folder={
        "datasets/cosmopedia-v2":70,
        "datasets/fineweb-edu-dedup":30,
    },
),

Otherwise the it doesn't load/save the right config


          make nanoset compatible with python

7323ce1

Member

3outeille commented Sep 5, 2024

lgtm

3outeille merged commit 3be44ef into huggingface:main

2 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet