Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize http-server #790

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mtozlu
Copy link

@mtozlu mtozlu commented Jan 11, 2022

Dockerization of http-server

Relevant issues

Closes #724

Contributor checklist
  • Provide tests for the changes (unless documentation-only)
  • Documented any new features, CLI switches, etc. (if applicable)
    • Server --help output
    • README.md
    • doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

Maintainers will do the building, tagging and pushing docker images.
These instructions are only for maintainers to release a new version in docker hub;

Building and Tagging the Docker Image

  • Make sure to checkout the desired version/branch before building docker image for that version
  • Run docker build -t {your-username}/http-server:{new-version} -t {your-username}/http-server:latest . in project root folder.
    This builds and tags the docker image with "latest" tag and also with the version you provide.

Pushing the Docker Image

  • After successful build, you can push all tags to your docker repository
  • Push the version tag: docker push {your-username}/http-server:{new-version}
  • Push the "latest" tag: docker push {your-username}/http-server:latest

Note: I already have the http-server images built in docker hub in my own repository (which is tozlu/http-server), if you would like to maintain docker images in your own repository, please change README and the build/push scripts above to reflect your username for docker hub.

@gaby
Copy link

gaby commented Jan 16, 2022

@mtozlu Have you try running the final bin with Google Distroless images?

FROM gcr.io/distroless/nodejs:16

@mtozlu
Copy link
Author

mtozlu commented Jan 17, 2022

@gaby No. But it looks cool. Should I switch to it? What are the benefits over alpine?

@gaby
Copy link

gaby commented Jan 17, 2022

@gaby No. But it looks cool. Should I switch to it? What are the benefits over alpine?

If it runs fine, I would say yes.

@rohitagre rohitagre mentioned this pull request Oct 16, 2023
8 tasks
@indexzero
Copy link
Collaborator

Similar to #790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http-server dockerized
3 participants