Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Headers #687

Closed

Conversation

einfallstoll
Copy link

@einfallstoll einfallstoll commented Jun 1, 2021

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

Finished #64 and supports custom headers being added.

What changes did you make?

Provide some example code that this change will affect, if applicable:

http-server -H 'X-Custom: Test'

Is there anything you'd like reviewers to focus on?

Please provide testing instructions, if applicable:

Fixes #684, fixes #174, fixes #334

@Tofandel Tofandel mentioned this pull request Jul 23, 2021
@thornjad thornjad added this to the Custom headers milestone Aug 16, 2021
@thornjad
Copy link
Member

Closing in favor of the simpler and older solution in #282

@thornjad thornjad closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants