Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View Task Instructions without login #6592

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

View Task Instructions without login #6592

wants to merge 8 commits into from

Conversation

royallsilwallz
Copy link
Contributor

What type of PR is this?

  • 🍕 Feature

Related Issue

Describe this PR

This PR enables user to share the task instructions URL of a project without having to log in to Tasking Manager.

Key Changes

  • Add a Link button View Project Specific Instructions to the bottom of Description section
  • Create different URL routes for /instructions and /contributions
  • Show Project Detail Map instead of Task Map for Instructions page when not logged in

Screenshots

image

image

@royallsilwallz
Create different route paths for Instructions & Contributions
3c52fee 
- Add `tabname` param to `/projects/:id/` route
- Change local tab state to route param tabname
- Remove footer for instructions & contributions route
@royallsilwallz
Add button to navigate to Instructions page from Project Detail page
273624a
@royallsilwallz
Show Project Detail Map instead of Task Map when not logged in
d52d9dc 
- Enable task api call only when logged in
- Add `taskBordersOnly` props for directly zooming to tasks in `ProjectDetailMap`
- Zoom to task border initially
@royallsilwallz
Change View Instructions button to link
ba5a265
@royallsilwallz
Show only Instructions tab when not logged in
7eac6e0
@royallsilwallz
Navigate to login when Map a Task button is clicked without login
2e08ecd
@royallsilwallz
Navigate to login on route is not public
1447ba5
@royallsilwallz
Redirect back to Instructions page after login from Map a Task
111960f
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manjitapandey
Copy link

issue:
The instruction page is crashed when we try to open tasks instruction page of private projects.
Steps to reproduce:
Go to any private project's instruction without logging in.
Expected behavior:
The tasks permission denied page should be shown instead of crashing the page as in image:
image

@ramyaragupathy ramyaragupathy added this to the v4.8.2 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emi420 emi420 Awaiting requested review from emi420

Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
v4.8.2
Development

Successfully merging this pull request may close these issues.

Viewing task instructions without HOT TM account
3 participants
@royallsilwallz @manjitapandey @ramyaragupathy