Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in "backend.config.Settings" #6585

Closed
wants to merge 2 commits into from

Conversation

Rojf
Copy link

@Rojf Rojf commented Oct 1, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • [+] πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

There are two problems here:

  1. pedantic_core._pedantic_core.Validation Error: 1 validation error for Settings
    SENTRY_BACKEND_DSN

It was necessary to add Optional[str]

  1. pedantic_or._pedantic_core.Validation Error: 3 validation errors for Connection Config
    MAIL_USERNAME
    MAIL_PASSWORD
    MAIL_SERVER

It should have been changed from None to ""
The "ConnectionConfig" class is not optional for pydantic

Dockerfile Outdated
Comment on lines 39 to 44
apt-get -q install --no-install-recommends -y \
build-essential \
postgresql-server-dev-15 \
python3-dev \
libffi-dev \
libgeos-dev

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted Low

Sort these package names alphanumerically. See more on SonarCloud
Dockerfile Outdated
Comment on lines 67 to 68
apt-get -q install --no-install-recommends -y \
postgresql-client libgeos3.11.1 proj-bin curl && \

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted Low

Sort these package names alphanumerically. See more on SonarCloud
@Rojf Rojf changed the base branch from develop to tasking-manager-fastapi October 1, 2024 23:22
@github-actions github-actions bot removed scope: infrastructure dependencies Pull requests that update a dependency file scope: frontend labels Oct 2, 2024
Copy link

sonarcloud bot commented Oct 2, 2024

@Rojf Rojf marked this pull request as draft October 3, 2024 12:07
@Rojf Rojf marked this pull request as ready for review October 3, 2024 12:11
@Rojf Rojf closed this Oct 3, 2024
@Rojf Rojf deleted the tm-fastapi branch October 3, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant