Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jericho grounding accuracy #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OliBomby
Copy link

The jericho environment does not detect invalid actions correctly for any of the games except 905. This means the reported grounding accuracy is way higher than the actual value.

It looks for [! to determine verb errors, but every game handles verb errors differently. Like acorncourt says That's not a verb I recognise., or library says I didn't understand that sentence., or zork1 says I don't know the word X, or loose says "I haven't the slightest idea what you're referring to," murmurs the egg. or "Huh?" The wolf raises an eyebrow., or snacktime says That's not a trick you know.. Partial valid verbs respond with I only understood you as far as wanting to X. I beg your pardon? if you say nothing.

This PR fixes the issue and reports the actual grounding accuracy in Jericho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant