Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makie and Plots support #31

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Add Makie and Plots support #31

merged 6 commits into from
Nov 20, 2023

Conversation

henry2004y
Copy link
Owner

@henry2004y henry2004y commented Nov 20, 2023

  • Add Makie as an extension
  • Recover Plots support
  • Add tests to Makie and Plots
  • Make the transpose consistent in getdata

#21 #29

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (4efa0d5) 66.62% compared to head (a1dcc04) 67.53%.

Files Patch % Lines
src/plot/pyplot.jl 43.05% 41 Missing ⚠️
ext/BatsrusMakieExt/typerecipe.jl 65.00% 7 Missing ⚠️
src/plot/plots.jl 66.66% 5 Missing ⚠️
src/io.jl 40.00% 3 Missing ⚠️
src/select.jl 50.00% 3 Missing ⚠️
src/plot/utility.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   66.62%   67.53%   +0.90%     
==========================================
  Files           9       11       +2     
  Lines        2331     2353      +22     
==========================================
+ Hits         1553     1589      +36     
+ Misses        778      764      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henry2004y henry2004y merged commit cfcec4b into master Nov 20, 2023
5 of 6 checks passed
@henry2004y henry2004y deleted the new_plot branch November 20, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant