Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #30

Merged
merged 7 commits into from
Nov 19, 2023
Merged

Refactoring #30

merged 7 commits into from
Nov 19, 2023

Conversation

henry2004y
Copy link
Owner

@henry2004y henry2004y commented Nov 18, 2023

#29

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (421f387) 66.72% compared to head (9dfed99) 66.62%.

Files Patch % Lines
src/io.jl 86.40% 14 Missing ⚠️
src/plot/pyplot.jl 43.47% 13 Missing ⚠️
src/vtk.jl 0.00% 2 Missing ⚠️
src/plot/plots.jl 0.00% 1 Missing ⚠️
src/plot/utility.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   66.72%   66.62%   -0.10%     
==========================================
  Files           9        9              
  Lines        2341     2331      -10     
==========================================
- Hits         1562     1553       -9     
+ Misses        779      778       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henry2004y henry2004y marked this pull request as ready for review November 19, 2023 22:49
@henry2004y henry2004y merged commit 4efa0d5 into master Nov 19, 2023
5 of 6 checks passed
@henry2004y henry2004y deleted the refactor branch November 19, 2023 22:50
@henry2004y henry2004y restored the refactor branch November 19, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant