-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme clarifications #238
Conversation
I believe the "Go to definition" issue is reported in haskell#192
I'm also having trouble with the "Renaming via I'm following the HaRe installation instructions, but encountering an error:
I'd report this issue in the HaRe repo if issue reporting was available. It also seems like this statement doesn't align with the feature listed in this repo.
|
Thanks a lot, they are all sensible updates. However i think "Go to definition" has different behaviours between haskell lang servers variants and all of them supports go to defs between files of the same component (and even between components, although not in a reliable way) |
I'm having the same issue. I see this hasn't been merged yet, so I was expecting to be able to jump to definition within the same project at least, since this is how the feature typically works with other language extensions. Without jump to definition and rename symbol, working with haskell in VSCode is a bit like the bad old days of javascript (lots of regular expressions and crossing of fingers). At least the LS will tell you if you borked your rename, but not being able to locate a symbol definition is painful. If the tooltip on hover at least gave the line number of the file it would be a little less so. |
Nothing is expected to work with the HIE backend anymore. We strongly recommend moving to Haskell Language Server. There is no one left supporting HIE and all the features are being absorbed into HLS. |
So perhaps this section needs to be clarified in the readme. Maybe remove HIE as an option.
|
I note that HIE was recently archived as a repo, so yes, I think it should be something along the lines of unsupported and legacy. |
README.md
Outdated
@@ -20,7 +20,7 @@ Language server client for haskell using the [HIE](https://github.com/haskell/ha | |||
* Diagnostics via HLint and GHC warnings/errors | |||
* Code actions and quick-fixes via [`apply-refact`](https://github.com/mpickering/apply-refact) (click the lightbulb) | |||
* Type information and documentation (via hoogle) on hover | |||
* Jump to definition (`F12` or `Go to Definition` in command palette) | |||
* Jump to definition (`F12` or `Go to Definition` in command palette). Note that this only works for definitions within the current file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this limitation is gone now in newer versions of ghcide (and hls)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it still does not work for non local package definitions (i.e. libraries)
I've updated the readme to reflect that HIE is legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes to reflect actual state of things
@milesfrain sorry for the delay in the final review. As the first block changed to remove references to hie i had to choose the actual master version in the rebase. I've kept the clarifications in the debugging part. Thanks! |
I believe the "Go to definition" issue is reported in #192