Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to library definition #192

Closed
Swoorup opened this issue Jan 14, 2020 · 6 comments
Closed

Go to library definition #192

Swoorup opened this issue Jan 14, 2020 · 6 comments
Labels
type: enhancement An enhancement to an already existing feature

Comments

@Swoorup
Copy link

Swoorup commented Jan 14, 2020

Does this extension support viewing library source files, similar to intellij-haskell via Go To Definition?

@Avi-D-coder
Copy link
Contributor

Not yet. It's blocked on ghcide integration, and then ghcide gaining support.

@jneira jneira added the type: enhancement An enhancement to an already existing feature label May 25, 2020
@jneira
Copy link
Member

jneira commented May 25, 2020

Only note that the ghcide integration is being done in haskell-language-server.

@andys8
Copy link

andys8 commented May 27, 2020

@jneira could you explain why this is part of haskell-language-server and not ghcide to help with my understanding? What about this issue, where it says it's already jumping somehwhere https://github.com/digital-asset/ghcide/issues/509 ? Thanks :)

@fendor
Copy link
Collaborator

fendor commented May 27, 2020

Haskell Language Server is based on the ghcide fork of mpickering that supports loading multiple components in the same session. This fork is not merged yet, see haskell/ghcide#522. As HLS is more experimental, we move faster and break things faster. That is why HLS currently has more features and especially more bleeding edge stuff.

The mentioned issue is about jumping to definitions in the same component, e.g. library component, which already works reliably, afaik.

@andys8
Copy link

andys8 commented May 27, 2020

Thank you

milesfrain added a commit to milesfrain/vscode-hie-server that referenced this issue Jun 18, 2020
I believe the "Go to definition" issue is reported in haskell#192
@jneira
Copy link
Member

jneira commented Mar 9, 2021

Thanks for reporting the issue.
It is not implemented yet, the issue in the lsp server backend tracking the feature request is haskell/haskell-language-server#708

@jneira jneira closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An enhancement to an already existing feature
Projects
None yet
Development

No branches or pull requests

5 participants