Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Put IdeResult in terms of Either, add ideError #1611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gurkenglas
Copy link
Contributor

Let's try this again.

@Avi-D-coder
Copy link
Collaborator

Avi-D-coder commented Jan 27, 2020

@Gurkenglas What is the motive for this change?
It is allot more concise.

@Gurkenglas
Copy link
Contributor Author

You have answered your question :3

@jneira
Copy link
Member

jneira commented Jan 28, 2020

Thanks for the pr, i think the intent is good and i always like the prs that remove locs (the actual new type has its own advantages though).
However, as you surely already knows, we just have start a process of integration with ghcide so it is the actual main focus.
We will continue to fix bugs but we will prefer that the new code or internal refactorings go in that direction (see #1416 (comment)).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants