[WIP] enable Sentinel tutorials without requiring them #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
zchsh
changed the title
zchsh
changed the title
Rationale for reverting th basePaths change: we only ever use product data basePaths for redirects from the previous dot-io sites. This property should likely be renamed, or perhaps removed entirely, as redirects could probably be written in a more static way now that we've completed our migration to Dev Dot. Rationale for reverting the rootDocsPath change: up until the point we fully remove intro content, including the page files, we need to maintain this data, otherwise the build will fail. Recommendation is to remove intro content in a separate PR.
Holding until Sentinel tutorials are published
zchsh
force-pushed
the
zs.add-sentinel-tutorials
branch
from
ff3658f
to
e98c2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is based on dev-portal#2508 - Create sentinel tutorials section from intro docs
🗒️ What
This PR fixes a few small issues discovered when trying to run the Tutorials content workflows locally.
🛠️ How
IconTile, adds support forsentinelandhcp"brand colors"PRODUCT_ICON_MAPfor card badges to includesentinelas an optionHlogofetchAllCollectionsByProductto split out setting ofthemethemeandproduct.slugcan be the same value. For Sentinel, this errors.themeto a separate argument, and makes it optional, so that Sentinel can render without error.collection-viewserver to render Sentinel collectionsthemeandproduct.slug.sentineltheme, so this would result in zero collection pages. This PR updates to add a conditional similar to the one used for HCP content to render all Sentinel collections.🧪 Testing
To fully test these changes, run the full end-to-end content workflows for Tutorials locally. A more detailed guide: 2024-09-11 - tutorials local setup