Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows #65

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Windows #65

wants to merge 2 commits into from

Conversation

hanazuki
Copy link
Owner

@hanazuki hanazuki commented Aug 11, 2021 •
edited
Loading

#63

@hanazuki hanazuki mentioned this pull request Aug 11, 2021
Open
@hanazuki
Copy link
Owner Author

hanazuki commented Aug 19, 2021 •
edited
Loading

jsonnet.dll needs to be installed next to node-jsonnet.node so that node-jsonnet.node can find the DLL. (Or should we static link?)

Also, we need to fix the tests to accept Windows-style newlines (\r\n).
I have no idea how Unicode filenames are handled by Node.js on Windows.

@hanazuki hanazuki linked an issue Dec 2, 2021 that may be closed by this pull request
Install fails on Windows/MSVC #63
Open
@hanazuki hanazuki added the help wanted Extra attention is needed label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install fails on Windows/MSVC
1 participant
@hanazuki