feat: implement WorkspaceSvg class manipulation
#8473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
…' into workspace-svg-class-manipulation
BeksOmega
requested review from
BeksOmega
and removed request for
rachel-fenichel
BeksOmega
approved these changes
Aug 12, 2024
Co-authored-by: Beka Westberg <[email protected]>
Co-authored-by: Beka Westberg <[email protected]>
|
I accepted both of those. Sorry about those commit names- I didn't notice that it was using the default name when accepting the suggestion. |
|
No worries at all! Thank you for your work on this =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8281
Proposed Changes
Implements
addClassandremoveClassmethods to theWorkspaceSvgclass.Reason for Changes
As requested in #8281
Test Coverage
Ran the usual build/test scripts and also made sure it worked okay in the playground.
Documentation
Yes, add docs for the new methods
Additional Information