Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose bringToFront() method #8472

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

UCYT5040
Copy link
Contributor

@UCYT5040 UCYT5040 commented Aug 7, 2024

The basics

The details

Resolves

Fixes #8233

Proposed Changes

Removes the @internal from the JSDoc, adds some info about the cost of the function, and also removes an extra colon in the JSDoc.

Reason for Changes

Described in the original issue #8233

Test Coverage

Tested manually with browser console in the playground (although I believe the function was working before this, as this change only relates to JSDoc).

Documentation

Yes, documentation for BlockSvg should include the bringToFront() method.

Additional Information

@UCYT5040 UCYT5040 requested a review from a team as a code owner August 7, 2024 12:00
@UCYT5040 UCYT5040 requested a review from BeksOmega August 7, 2024 12:00
@github-actions github-actions bot added the PR: feature Adds a feature label Aug 7, 2024
@BeksOmega
Copy link
Collaborator

Heya @UCYT5040 In the future please comment on an issue before working with on it! Just helps prevent duplicate work from occuring =)

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great =) Once this passes CI I'll get it merged!

@BeksOmega BeksOmega merged commit 23e9011 into google:develop Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose bringToFront() method
2 participants