Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. #8469

Closed
wants to merge 4 commits into from

Conversation

Adityajaiswal03
Copy link

solves #8290

@Adityajaiswal03 Adityajaiswal03 requested a review from a team as a code owner August 7, 2024 06:42
Copy link

google-cla bot commented Aug 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen August 7, 2024 16:31
@BeksOmega BeksOmega assigned BeksOmega and unassigned cpcallen Aug 7, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thank you for the fixes! Once this passes CI I'll get it merged =)

@BeksOmega
Copy link
Collaborator

Ah actually it looks like you haven't signed the CLA @Adityajaiswal03 , could you go ahead and do that for me?

@Adityajaiswal03 Adityajaiswal03 changed the title BlockEditableText Changes to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. Aug 8, 2024
@github-actions github-actions bot added the PR: feature Adds a feature label Aug 8, 2024
@Adityajaiswal03
Copy link
Author

Hi @BeksOmega , I have already signed the Contributor License Agreement (CLA), but it appears that it has not been processed yet. Could you please assist me with this issue?

@BeksOmega
Copy link
Collaborator

Hello @Adityajaiswal03

Have you tried following the instructions in the check response?

Help! I've signed the CLA, but it's still showing me as unsigned.

Individual signers

Corporate signers

  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
  • The email used to register you as an authorized contributor must be the same email used in your Git commits. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.
  • You may have Keep my email address private enabled. Without a visible email address, the CLA cannot be checked. Uncheck it and re-create the offending commit, or have your CLA point of contact add your @users.noreply.github.com address to the CLA group.

@Adityajaiswal03
Copy link
Author

@BeksOmega, I'm still encountering the issue, so I'm going to delete this PR and create a new one against the same branch.

@Adityajaiswal03 Adityajaiswal03 deleted the branch google:rc/v12.0.0 August 9, 2024 06:26
@Adityajaiswal03 Adityajaiswal03 deleted the rc/v12.0.0 branch August 9, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants