Issue#7428 #8468
Closed
Issue#7428 #8468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
requested changes
Aug 6, 2024
Comment on lines
+245
to
+247
| .blocklyDisabled > .blocklyOutlinePath { | ||
| fill: darkgray !important; | ||
| } |
There was a problem hiding this comment.
I don't think you want to add this here. I think you want to modify the code in the zelos constants file getCSS_. You should be able to remove the !important declaration then.
And could you try just setting the stroke of the outline path instead of setting the fill? I think that might look nicer!
|
I will look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7428 - Zelos hides disabled blocks placeholders.
Proposed Changes
This pull request addresses an issue where placeholders for disabled blocks were not visible in the Zelos renderer. The changes involve modifying the CSS to ensure that the placeholders are displayed consistently, similar to the behavior in the Geras renderer.
Reason for Changes
The issue made it difficult for users to connect disabled blocks together, as the placeholders were not visible. This fix improves the usability of the Zelos renderer by ensuring that placeholders are always visible, even when blocks are disabled.
Test Coverage
The changes were manually tested by:
Documentation
No additional documentation is needed, as this change only affects the internal CSS styling.
Additional Information
None.