-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: deleted styles without associated classes from css.ts, issue #8285 #8465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thank you for the fixes! Once this passes CI I'll get this merged =)
In the issue, it is mentioned as "This should be merged into the rc/v12.0.0 branch. It should be marked as a breaking change.". Wanted to check if there is anything to be done from my end |
Ah yes I missed that, you need to rebase onto the To rebase onto the rc/v12.0.0 branch, you can follow these steps.
Once you've done this, the PR should be on the correct branch. Let me know if you have any questions or run into any issues! |
8b10c8e
to
1e63985
Compare
hi @BeksOmega did the required changes. Let me know if anything to be done from my side! |
Thank you for your work on this @aishwaryavenkatesan :D |
The basics
2. blocklyResizeLine
3. blocklyResizeSW
4. blocklyResizeSE
5. blocklyDropDownButton
The details
Resolves
Fixes issue #8285
Link: #8285
Proposed Changes
I have deleted the styles blocklyHidden, blocklyResizeLine, blocklyResizeSW, blocklyResizeSE and blocklyDropDownButton
from css.ts
Reason for Changes
These styles are deleted as they are not used by any other classes
Test Coverage
executed commands
npm run build
npm run format and npm test commands.
All 10 tests passed
Documentation
No documentation required
Additional Information