Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unneeded exception #18166

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Drop unneeded exception #18166

merged 2 commits into from
Oct 31, 2024

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Oct 31, 2024 •
edited by orthagh
Loading

Description

Fix for #18165

cedric-anne
cedric-anne reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the return; on line 64.

@cedric-anne
Copy link
Member

You can also remove the return; on line 64.

And move the header('Content-Type: application/json'); on line 58.

@cedric-anne cedric-anne merged commit 18e587f into glpi-project:main Oct 31, 2024
7 checks passed
@trasher trasher deleted the fix-18165 branch October 31, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

@cconard96 cconard96 Awaiting requested review from cconard96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trasher @cedric-anne