Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: provide search options on model characteristics for computer, monitor and net device #17991

Draft
wants to merge 1 commit into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

btry
Copy link
Contributor

@btry btry commented Oct 2, 2024

I need to access power consumption from some asset models.

This PR adds interesting characteristics from models, but requires new IDs to workaround search options ID conflict

Note : Some properties are numbers, I think it would be useful to fix search types

Example Without searchtype
image

With search type

'searchtype' => ['equals', 'notequals', 'lessthan', 'morethan']

image

2 search types have bad labels, but this is out of scope of this PR.

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does

Screenshots (if appropriate):

@btry btry force-pushed the model_search_options branch 2 times, most recently from 20506c6 to 7673d67 Compare October 2, 2024 11:55
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
45.8% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@trasher trasher marked this pull request as draft October 29, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant