-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to phpunit #17355
Switch to phpunit #17355
Conversation
trasher
commented
Jun 25, 2024
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | No :D |
Adding these annotations to the PHPDoc of the Inventory test class fixes the outstanding test failure, but it is yet another workaround. Unfortunately adding the annotations in a parent class like GLPITestCase doesn't seem to work. /**
* @runTestsInSeparateProcesses
* @preserveGlobalState disabled
*/ |
Thanks, it seems that works! I've tried similar annotations to fix other issues; but I did not try with this last remaining one... Annotating parent class won't work, it's stated in docs/issues I've read. |
76ec40d
to
4e2e67b
Compare
Maybe adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not reviewed all the tests yet.
Do you plan to convert all the tests in a unique PR?
As I said in internal channel, using process-isolation with phpunit 9.6 does not works. It does with phpunit >= 10. |
No, I tried in the past, this takes too much time, dealing with changes in existing tests is a nightmare. Current PR moves existing atoum tests, so both can run at the same time. I'll open other PR's to migrate other tests later (in facts, there is already one other that is almost ready). |
Proceed some conversions Provider expet an array of array Add phpunit XML file