-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep only one directory for tests #17257
Keep only one directory for tests #17257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 10.0/bugfixes #17257 +/- ##
=================================================
+ Coverage 44.39% 44.91% +0.52%
=================================================
Files 232 215 -17
Lines 37928 35943 -1985
=================================================
- Hits 16837 16144 -693
+ Misses 21091 19799 -1292 ☔ View full report in Codecov by Sentry. |
d8c64b0
to
bbed3d6
Compare
bbed3d6
to
9f8328d
Compare
I do not understand the fail on CronTask test; I do not reproduce on my instance :( |
770db3a
to
9cc1837
Compare
This was due to the presence of files generated by other test methods. My last commit should fix it. |
Are you sure about this ? On my machine the IMO we should be moving in the opposite direction by fixing our tests so that they can all run concurrently without issues. |
Also, out of these 106 seconds of tests, only 20 seconds are used to run the actual tests content + before/after hooks. I am curious where the others 86 seconds come from, if its just from the atoum framework that seems super excessive :/ |
For execution times; I check difference on github action, not on my local computer. Time was the same with mcn set to 1 (a few seconds less or more). I do not consider that as something to be fixed: tests take time, we surely can improve several other parts of the core code or the process. Also, atoum is dead and will be replaced with phpunit - problems and cause will differ. |
* Keep only one directory for tests * Fix namespaces * Make the CronTask::testCronTemp() test more resilient * Remove remaining usages of the tests/unit dir * Remove unit from coverage, add codecov token --------- Co-authored-by: Cédric Anne <[email protected]>
* Keep only one directory for tests * Fix namespaces * Make the CronTask::testCronTemp() test more resilient * Remove remaining usages of the tests/unit dir * Remove unit from coverage, add codecov token --------- Co-authored-by: Cédric Anne <[email protected]>
The
unit
directory is run with an 10 children subprocesses; but that no longer have sense since there are very few tests in there; and execution time is the same when parameter is set to 1.I think it's easier having all files in one directory only