Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for GLPI 11 #554

Closed
wants to merge 4 commits into from
Closed

Prepare for GLPI 11 #554

wants to merge 4 commits into from

Conversation

trasher
Copy link
Collaborator

@trasher trasher commented Sep 30, 2024

No description provided.

Plugins::getWebDir() has been deprecated
parent can* methods now have explicit type return
Fix setup page display (partial)
@trasher trasher marked this pull request as ready for review September 30, 2024 13:28
@trasher
Copy link
Collaborator Author

trasher commented Sep 30, 2024

It's a bit dumb to deprecate one method to create another local one; but it's impossible to work with all depreciations message everywhere.
Or we wait for 11 release to get a specific compliant version; up to you.

@cedric-anne
Copy link
Member

It's a bit dumb to deprecate one method to create another local one; but it's impossible to work with all depreciations message everywhere.

You can also add the deprecation error suppression operator for this specific method: @Plugin::getWebDir(...).

Or we wait for 11 release to get a specific compliant version; up to you.

We used to not anymore have releases that are compliant with 2 distinct major/intermediate GLPI version due to this.

@trasher trasher closed this Sep 30, 2024
@trasher
Copy link
Collaborator Author

trasher commented Sep 30, 2024

So let's wait for 11.

@trasher trasher deleted the feature/glpi11 branch September 30, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants