hicBuildMatrix: allow zero min repeats for bins so not compulsorily on the command line #6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binsize - answers are different!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binsize is currently in a form repeat with default length of 1 and a single default value so it always appears on the command line - there is no way to run the tool without it at present.
This PR changes those repeat limits to zero. That allows binsize not to be set, so the command line does not have
--binsize. Sometimes that may be appropriate. It certainly appears to have an effect on the way things are reported..New test added and test artifacts numbered so they can be compared - the new test without binsize gives very different outputs to the otherwise identical existing test with a binsize of 5k. At least this PR gives a user the opportunity to not use binsize FWIW.