Small comment round up #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverbeck
approved these changes
Feb 22, 2023
uniqueg
reviewed
Feb 24, 2023
There was a problem hiding this comment.
Thanks @denis-yuen - great update. I added quite some comments to the README.md, maybe you will find them useful. If not, just ignore :)
Ended up addressing these in #238 so that documentation and process updates remain there (while the two new openapi changes remain here) |
uniqueg
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small additions from the backlog to exercise the build fixes in #238
The actual changes are the commits from 6b0600d onwards
Adds tag-based search, this was feedback from a TRS update. The idea being that we could add tag-based search. As a request, this would look like
https://ga4gh.github.io/ga4gh/trs/v2/tools?tags=category1,category2,category3Add a tool version specific description