Add list of known attributes that can be included in the digest #12
Conversation
|
I opened a new PR to handle the mandatory question, But this still isn't quite solidified because it mentions the order array, which is still pending, right? |
|
|
||
| ### Known limitations | ||
|
|
||
| - After long discussion, we decided that storing an order array to explicitely was going to bring too many complications so we decided against it. This will limit (but not negate) our ability to find collections that have the same content but where the element. are in a different. |
There was a problem hiding this comment.
I think I would just leave this for the other ADR entry that discusses it in detail.
|
|
||
| ### Decision | ||
|
|
||
| The attributes allowed to be used in the sequence collection digest construction are: |
There was a problem hiding this comment.
I'm not sure if 'allowed' is the right word here -- since we allow everything, really. I think it's more like, these are the controlled vocabulary terms for the basic, universal seqcol spec....
Maybe:
"The initial set of controlled vocabulary terms for sequence collection attributes included in the digest construction are: "
And then I think I'd also add to this ADR the decision that additional custom attributes are allowed.
|
You could link this issue in to this one: #8 |
|
@tcezard I think the thing we discussed today about a protocol for determining external names for inclusion will actually supercede this point. Therefore, I suggest we close this PR in favor of the one you were going to prepare that discusses the new decision on this topic. |
|
Yes this can be closed. |
Here is a proposal we discussed for fixing the list of attributes that can be use in the construction of the digest.
#8