-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slider): improve slider variants and gapratio #3111
Merged
Merged
+255
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
Any issue which is a bug or PR which fixes a bug
type/feat
Any feature requests or improvements
lang/css
Anything involving CSS
state/awaiting-reviews
Pull requests which are waiting for reviews
javascript
Pull requests that update Javascript code
labels
Oct 23, 2024
lubber-de
added
the
state/awaiting-docs
Pull requests which need doc changes/additions
label
Oct 23, 2024
An enhanced variant of the solution in #3100 is implemented as well by using |
prudho
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice changes ! LGTM 👍
lubber-de
added a commit
that referenced
this pull request
Oct 31, 2024
Missing and new types for slider matching the feature s of #3111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
lang/css
Anything involving CSS
state/awaiting-docs
Pull requests which need doc changes/additions
state/awaiting-reviews
Pull requests which are waiting for reviews
type/bug
Any issue which is a bug or PR which fixes a bug
type/feat
Any feature requests or improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the slider component, so it
vertical right aligned
fixed
forautoAdjustLabels
highlightRange
to slightly highlight the selected area rangeui label
Screenshot
Testcase
https://jsfiddle.net/lubber/1tvumckq/48/
Closes
#3103