Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Building hangs on 'create install files' #309

Merged
merged 1 commit into from
Dec 18, 2018
Merged

[Build] Building hangs on 'create install files' #309

merged 1 commit into from
Dec 18, 2018

Conversation

ColinFrick
Copy link
Member

After using a prompt, the next gulp task hangs.
Because we don't really need the prompt to be executed in a gulp pipe, we can just use Inquirer.js directly.

There is an open issue on the gulp-prompt repository (on which prompt-sui is based): Freyskeyd/gulp-prompt#63

Closes

#307

There is an open issue on the gulp-prompt repository (on which prompt-sui is based): Freyskeyd/gulp-prompt#63
@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process labels Dec 17, 2018
@ColinFrick ColinFrick added this to the 2.7.0 milestone Dec 17, 2018
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami
Copy link
Member

y0hami commented Dec 17, 2018

This looks good but I'm going to hold off merging for now until travis is fixed since the PR changes the package-lock.json file and I don't want to cause any conflicts

@y0hami y0hami added state/awaiting-reviews Pull requests which are waiting for reviews state/on-hold Issues and pull requests which are on hold for any reason and removed state/awaiting-reviews Pull requests which are waiting for reviews state/on-hold Issues and pull requests which are on hold for any reason labels Dec 17, 2018
@y0hami y0hami merged commit 2438edb into fomantic:develop Dec 18, 2018
This was referenced Dec 21, 2018
@ColinFrick ColinFrick deleted the fix/307 branch January 5, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants