chore: improve ci stability

filecoin-project · Jul 17, 2023 · 77d5a73 · 77d5a73
1 parent 858169d
commit 77d5a73
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/manual.yml b/.github/workflows/manual.yml
@@ -42,7 +42,7 @@ jobs:
           METAMASK_MNEMONIC: ${{ inputs.metamask-seed }}
           METAMASK_PASSWORD: ${{ inputs.metamask-password }}
           METAMASK_SNAP_ID: ${{ inputs.metamask-snap-id }}
-          MEtAMASK_SNAP_VERSION: ${{ inputs.metamask-snap-version }}
+          METAMASK_SNAP_VERSION: ${{ inputs.metamask-snap-version }}
       - uses: actions/upload-artifact@v3
         if: always()
         with:

diff --git a/packages/snap/src/utils.ts b/packages/snap/src/utils.ts
@@ -205,7 +205,7 @@ export async function snapDialog(
     params,
   })
 
-  return result as boolean
+  return result === true
 }
 /**
  * Update the messages in the state

diff --git a/packages/snap/test/e2e/1-methods.spec.ts b/packages/snap/test/e2e/1-methods.spec.ts
@@ -168,8 +168,8 @@ test.describe('filsnap testnet', () => {
     const from = 't1pc2apytmdas3sn5ylwhfa32jfpx7ez7ykieelna'
     const to = 't1sfizuhpgjqyl4yjydlebncvecf3q2cmeeathzwi'
 
-    metamask.on('notification', (page) => {
-      void page.getByRole('button').filter({ hasText: 'Approve' }).click()
+    metamask.on('notification', async (page) => {
+      await page.getByRole('button').filter({ hasText: 'Approve' }).click()
     })
 
     const message = {
@@ -186,7 +186,7 @@ test.describe('filsnap testnet', () => {
       })
 
     if (signedMessageResponse.error != null) {
-      throw new Error('Failed to sign message')
+      throw new Error(signedMessageResponse.error.message)
     }
 
     const sendResponse = await metamask.invokeSnap<SendMessageResponse>({

diff --git a/packages/snap/test/e2e/messages.spec.ts b/packages/snap/test/e2e/messages.spec.ts
@@ -48,8 +48,8 @@ test.describe('snap messages', () => {
     const from = 't1pc2apytmdas3sn5ylwhfa32jfpx7ez7ykieelna'
     const to = 't1sfizuhpgjqyl4yjydlebncvecf3q2cmeeathzwi'
 
-    metamask.on('notification', (page) => {
-      void page.getByRole('button').filter({ hasText: 'Approve' }).click()
+    metamask.on('notification', async (page) => {
+      await page.getByRole('button').filter({ hasText: 'Approve' }).click()
     })
 
     const message = {