-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subfolder git detection #9
Conversation
@Alhadis done. |
- Also fix code style
@utkarshgupta137 Could you give me an example of the sort of problem you were trying to fix? I'm noticing that repository icons are sporadically disappearing. 🤔 |
Same issue as atom/tree-view#1366 Anyways, I've not faced any issues. |
Hey, if everything looks good, can you release a new version? |
Your changes broke the package's ability to display repository icons, so, no. 😜 |
Can you share an example? I've'nt been able to replicate what you're saying |
I assume that's because you have |
Ah okay. I'll get it merged in tree-view first. |
Hey, I'm not sure when the required commit will get merged in tree-view. Meanwhile, we can keep both old & new logic, so none of the existing functionality is broken? |
Aye, I'll patch it once I've finished setting up my new MacBook: I took your advice and bought a 16" Intel-powered MacBook Pro, because there's no fucking way I'm waiting half a year for the 16" M1X laptops to drop. Yeah, M1 might be orders of magnitude faster, but to somebody who's been stuck with antique hardware for the last 3 years, anything released within that timespan feels equally fast. 😒 (I'm still trying to reassure myself I did the right thing, so please forgive the rambling monologue...) |
Nice! I am looking at this from the same machine. Do try pock for touch bar. |
@utkarshgupta137 Would you mind giving the latest changes a whirl? Don't forget to pull from |
Looks good to me |
Done! Released as v0.2.0. 😀 Thanks so much once again for your help! |
Use atom's atom.project.repositoryForDirectory to find the repository for a given path.