Skip to content

Commit

Permalink
Faker::Games::Dota missing quotes and new heroes (#2907)
Browse files Browse the repository at this point in the history 
* feat: added new Dota 2 heroes

Muerta -  https://dota2.fandom.com/wiki/Muerta
Ringmaster - https://dota2.fandom.com/wiki/Ringmaster

* feat: add missing quotes for heroes (letter A)

Ancient Apparation - https://dota2.fandom.com/wiki/Ancient_Apparition/Responses
Anti Mage - https://dota2.fandom.com/wiki/Anti-Mage/Responses
Arc Warden - https://dota2.fandom.com/wiki/Arc_Warden/Responses

* feat: add missing quotes for heroes (letter B)

Bane - https://dota2.fandom.com/wiki/Bane/Responses
Batrider - https://dota2.fandom.com/wiki/Batrider/Responses
Bloodseeker - https://dota2.fandom.com/wiki/Bloodseeker/Responses
Bounty Hunter - https://dota2.fandom.com/wiki/Bounty_Hunter/Responses
Broodmother - https://dota2.fandom.com/wiki/Broodmother/Responses

* feat: add `centaur_warrunner` quotes

The hero is called `Centaur Warrunner` but in
`quotes` he's called just `centaur`. It causes
problems if users try to generate quote by
`parameterize(separator: '_')` the name.
I left old `centaur` to not brake people's code.

* feat: add missing quotes for heroes (letter C)

Chen - https://dota2.fandom.com/wiki/Chen/Responses
Clinkz - https://dota2.fandom.com/wiki/Clinkz/Responses
Crystal Maiden - https://dota2.fandom.com/wiki/Crystal_Maiden/Responses

* feat: add missing quotes for heroes (letter D)

Dark Seer - https://dota2.fandom.com/wiki/Dark_Seer/Responses
Dark Willow - https://dota2.fandom.com/wiki/Dark_Willow/Responses
Dawnbreaker - https://dota2.fandom.com/wiki/Dawnbreaker/Responses
Dazzle - https://dota2.fandom.com/wiki/Dazzle/Responses
Death Prophet - https://dota2.fandom.com/wiki/Death_Prophet/Responses
Disruptor - https://dota2.fandom.com/wiki/Disruptor/Responses
Drow Ranger - https://dota2.fandom.com/wiki/Drow_Ranger/Responses

* fix!: remove heroes that don't have quotes

And I also added `meepo` to the test because
he was missing

---------

Co-authored-by: Stefanni Brasil <[email protected]>
  • Loading branch information
@arthurka-o
arthurka-o and Stefanni Brasil committed Jun 11, 2024
1 parent 7d14d42 commit 21cdb13
Show file tree
Hide file tree
Showing 2 changed files with 127 additions and 73 deletions.
187 changes: 120 additions & 67 deletions lib/locales/en/dota.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,97 +42,30 @@ en:
- Earth Spirit
- Earthshaker
- Elder Titan
- Ember Spirit
- Enchantress
- Enigma
- Faceless Void
- Grimstroke
- Gyrocopter
- Hoodwink
- Huskar
- Invoker
- Io
- Jakiro
- Juggernaut
- Keeper of the Light
- Kunkka
- Legion Commander
- Leshrac
- Lich
- Lifestealer
- Lina
- Lion
- Lone Druid
- Luna
- Lycan
- Magnus
- Marci
- Mars
- Medusa
- Meepo
- Mirana
- Monkey King
- Morphling
- Naga Siren
- Nature's Prophet
- Necrophos
- Night Stalker
- Nyx Assassin
- Ogre Magi
- Omniknight
- Oracle
- Outworld Destroyer
- Pangolier
- Phantom Assassin
- Phantom Lancer
- Phoenix
- Primal Beast
- Puck
- Pudge
- Pugna
- Queen of Pain
- Razor
- Riki
- Rubick
- Sand King
- Shadow Demon
- Shadow Fiend
- Shadow Shaman
- Silencer
- Skywrath Mage
- Slardar
- Slark
- Snapfire
- Sniper
- Spectre
- Spirit Breaker
- Storm Spirit
- Sven
- Techies
- Templar Assassin
- Terrorblade
- Tidehunter
- Timbersaw
- Tinker
- Tiny
- Treant Protector
- Troll Warlord
- Tusk
- Underlord
- Undying
- Ursa
- Vengeful Spirit
- Venomancer
- Viper
- Visage
- Void Spirit
- Warlock
- Weaver
- Windranger
- Winter Wyvern
- Witch Doctor
- Wraith King
- Zeus
abaddon:
quote:
- You have called death upon yourself.
Expand All @@ -144,6 +77,23 @@ en:
- Easy now, this stuff is explosive!
- Better living through alchemy!
- Tell the ogre you're sorry.
ancient_apparition:
quote:
- Behold the apparition.
- Time to break the ice!
- I look again upon the cold light of day.
anti_mage:
quote:
- Truth compels me.
- I bring an end to magic.
- They who live by the wand shall die by my blade.
- It is not magic brings me back, but purity of will!
arc_warden:
quote:
- Matter has been split from its intended form. These must be made to unite.
- None escape the Self.
- These fools must learn what they stand against.
- Mercy is yours, for the end comes.
axe:
quote:
- Let the carnage begin.
Expand All @@ -152,11 +102,37 @@ en:
- Feel the axe of Axe!
- What happened? Axe happened!
- No business but war. No family but death. No mercy but the grave!
bane:
quote:
- Your Nightmare is here.
- Nightmares, follow me into the light.
- Knock knees and blood run cold!
- I dreamt a field of war…and woke to find myself upon it.
batrider:
quote:
- Death from above!
- One forest fire coming up!
- I'll have the brisket. My hoss'll have your head.
- You wanna play rough? All right, we'll play rough.
beastmaster:
quote:
- Meet your master…snuhg… beastmaster.
- I'm a natural disaster.
- A death not fit for man or beast.
bloodseeker:
quote:
- The search for blood begins.
- For the Flayed Twins, I seek blood.
- Enough hide and seek.
- Don't be negative...be positive!
bounty_hunter:
quote:
- There's a price on all their heads.
- No job is too big, no fee is too big.
- My blades will do the talking.
- Just business, nothing personal.
- Was there a bounty on me?
- It was just business before. Now it's personal.
brewmaster:
quote:
- I fight any thing in the house.
Expand All @@ -167,23 +143,94 @@ en:
- Time to mash some faces, I'd say.
- A good bashing, never hurt nobody.
- I'm more than a pretty face.
broodmother:
quote:
- The spider comes.
- You're not afraid of spiders, are you?
- I could kill you with five eyes closed.
- My enemies will pay with their liquified guts.
centaur:
quote:
- Long shall my name be remembered.
- I don't always wear a saddlebag, but when I do, I put this one in it.
- Hurts you more than it hurts me.
centaur_warrunner:
quote:
- Long shall my name be remembered.
- I don't always wear a saddlebag, but when I do, I put this one in it.
- Hurts you more than it hurts me.
chaos_knight:
quote:
- All that is light shall be cast in darkness.
- Like the heads of my enemies, this one is in the bag.
- We descend into chaos.
- The light shall be blackened, and chaos shall reign.
- Chaos is Fun…damental.
chen:
quote:
- The Inquisitor has arrived.
- The persecution starts now!
- Only the penitent can be forgiven.
- God taketh whom he loveth best.
- In the name of Obelis, I fight again.
clinkz:
quote:
- A light to guide my way. A light to burn my foes.
- Clink goes my bones.
- It's time for your cremation.
- I've already paid my pound of flesh.
- The furnace of my heart cannot be quenched.
clockwerk:
quote:
- I've a mind like a steel trap, and the physique to go with it!
- What time is it? It's killing time.
- A good offense is the best armor. Good armor is also good armor.
crystal_maiden:
quote:
- Who calls the Crystal Maiden?
- Behold the scourge of Icewrack!
- Swift as the wolves of Icewrack...
- You're dead and that's a cold hard fact.
- Once burned, ice shy...
dark_seer:
quote:
- From the land behind the wall, I come.
- Speed is the heart of battle.
- Face your enemy, face yourself.
- Your life, much like your head, lacked a point.
- Death is a wall I have overleapt.
dark_willow:
quote:
- Are you ready to have some fun, ya?
- No one will forget the name Mireska
- A little mischief never killed anyone... well, you I guess.
- Jex... whaddya say we find who did that and rip their eyes out?
dawnbreaker:
quote:
- Darkness fears the break of dawn!
- I was created to serve, but today I choose this fight.
- The first stars burned and faded into nothingness. Followed by countless more. I remain. And my hammer swings true.
- Even at a fraction of my best, I outshine you immeasurably.
- One must always remember that the sun also rises.
dazzle:
quote:
- Dazzle!
- Where my shadow falls, there falls my foe.
- You're under my protection.
- Resurrection comes easily to a Shadow Priest!
death_prophet:
quote:
- Who dares recall me from the grave?
- The doors of death open wide.
- You merely sipped at life. Now drink deep of death.
- The grave calls me back.
- Death is such a tease.
disruptor:
quote:
- The Stormcrafter comes!
- According to the forecast, this one is in the bag!
- Where you're going, the weather doesn't change.
- The storm charges my coil again.
doom:
quote:
- Face your demons.
Expand All @@ -197,6 +244,12 @@ en:
- Live by the sword, die by the dragon.
- Good night, Sven. I mean bad knight. [Talking to Sven]
- Never make a deal with a dragon, unless you're prepared to keep your end of it.
drow_ranger:
quote:
- My quiver and bow are ready!
- I thought they warned you not to speak with rangers.
- Autumn leaves for a deathbed.
- Faster than an arrow's flight.
earth_spirit:
quote:
- Body is flesh, but spirit immortal.
Expand Down
13 changes: 7 additions & 6 deletions test/faker/games/test_faker_dota.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@
class TestFakerDota < Test::Unit::TestCase
def setup
@tester = Faker::Games::Dota
@heroes = %w[abaddon alchemist axe beastmaster brewmaster bristleback centaur
chaos_knight clockwerk doom dragon_knight earth_spirit earthshaker
elder_titan huskar io kunkka legion_commander lifestealer lycan
magnus night_stalker omniknight phoenix pudge sand_king slardar
spirit_breaker sven tidehunter timbersaw tiny treant_protector tusk
underlord undying wraith_king]
@heroes = %w[abaddon alchemist ancient_apparition anti_mage arc_warden axe bane batrider beastmaster
bloodseeker bounty_hunter brewmaster bristleback broodmother centaur centaur_warrunner
chaos_knight chen clinkz clockwerk crystal_maiden dark_seer dark_willow dawnbreaker dazzle
death_prophet disruptor doom dragon_knight drow_ranger earth_spirit earthshaker
elder_titan huskar io kunkka legion_commander lifestealer lycan magnus meepo night_stalker
omniknight phoenix pudge sand_king slardar spirit_breaker sven tidehunter timbersaw tiny
treant_protector tusk underlord undying wraith_king]
end

def test_building
Expand Down

0 comments on commit 21cdb13

Please sign in to comment.