Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an extra is_hex_integer() function in validate.py and added extra condition to convert the hex_integer into a string hex_address #2127

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Sahma61
Copy link

@Sahma61 Sahma61 commented Aug 30, 2021

What was wrong?

Calling .transact({'from': accounts[0]}) throws TypeError: Address 0x... must be provided as a string, but .deploy({'from': accounts[0]}) does not which seems inconsistent. transact({'from': str(accounts[0])}) seems to solve the issue

How was it fixed?

Added an extra is_hex_integer() function in validate.py and added extra condition to convert the hex_integer into a string hex_address

Todo:

  • Need to add a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant