stagedsync: revert Sync.Run return error on bad block #12550
Merged
+1
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting this change because it broke the contract of
ExecutionEngine.UpdateForkChoice
. Previously callingexecutionPipeline.Run
would not return error upon bad block and would eventually reach this point where we set theForkChoiceReceipt.Status
toExecutionStatus_BadBlock
. Now, however, because of this newly returned error we never reach there and the response doesn't have the correct status. Checked with @JkLondon and looks like returning this error may not be necessary.This appeared during an Astrid run on mainnet as per the logs below. Astrid relies on a response with correctly set
ExecutionStatus_BadBlock
status so that it marks the block as bad and continues the chain tip sync. If the error from execution engine is anything else it is treated as an operational node error (meaning some logical/unexpected error happened) which is non-recoverable and terminates the process.